DanielLeens commented on PR #10680: URL: https://github.com/apache/seatunnel/pull/10680#issuecomment-5011097366
Hi @xyueji, I picked this PR up because the data-loss scenario is important and the original direction is valuable. I pushed commit 0570563e5b to the existing branch and completed the remaining safety work: the sink now checks the existing StarRocks label state before deciding whether to finish or retry, only creates a new label after an ABORTED transaction, preserves the batch for UNKNOWN/errors/interruption, and no longer guesses from exception text in the manager. I also updated the stale manager test and added direct coverage for VISIBLE, COMMITTED, ABORTED, UNKNOWN, Label Already Exists, retry exhaustion, zero retries, retained batches, and interruption. Local validation passed: Spotless, 16 focused tests, and the full -DskipTests verify. Thank you for surfacing this real reliability issue and for starting the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
