DanielLeens commented on PR #11337: URL: https://github.com/apache/seatunnel/pull/11337#issuecomment-5014639143
Thanks @SEZ9. I addressed the review feedback on the current head `09ff7f6086`. Key updates: - Rebuilt the PR on the current review base and removed the unrelated `FileMapStore.java` / `FileMapStoreTest.java` changes. The PR now contains exactly 28 Python connector, registration, documentation, and E2E files. - Reworked `PythonSourceReader` around asynchronous stdout/stderr pumps and bounded queues so `pollNext` no longer blocks indefinitely under the source checkpoint lock, and `close()` can terminate the direct Python process and unblock pending reads. - Added lifecycle regression coverage for non-terminating scripts, delayed output, cancellation/close, non-zero exits, invalid rows, working-directory behavior, and inherited stderr pipes. - Added the connector E2E module and label-scope registration. - Renamed the public plugin identity to `Python` and the option to `python.working.directory` before release. - Added explicit arbitrary-command-execution/security guidance to both English and Chinese docs and aligned the connector changelog/docs wording. Local validation: - `spotless:apply`: passed. - Connector dependency closure install with JDK 8: passed. - `PythonSourceFactoryTest` + `PythonSourceTest`: 17 tests, 0 failures, 0 errors, 0 skipped. - The focused Python E2E case was also validated locally in the implementation worktree. The new Build is queued on this exact head. Could you please re-review when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
