DanielLeens commented on PR #11139: URL: https://github.com/apache/seatunnel/pull/11139#issuecomment-5021859577
Thanks @SEZ9 for the independent review. I agree with Issue 1: the direct `waitForJobCompleteV2()` call is outside a real test deadline, so a lost terminal result can hold the CI executor for many hours. That is the same technical blocker recorded in my self-review. One clarification on Issue 2: `ClientJobProxy.waitForJobCompleteV2()` already wraps `doWaitForJobComplete().get()` in `RetryUtils.retryWithException(...)` and retries operation-level transient failures (`ClientJobProxy.java:93-106`). The missing contract here is a bounded overall deadline, not the absence of transient-operation retry. The literal-string consistency note is non-blocking. This self-authored PR remains blocked until the wait is bounded and still needs independent maintainer approval afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
