nielifeng commented on PR #11465: URL: https://github.com/apache/seatunnel/pull/11465#issuecomment-5032183154
@dybyte Added the requested WALReader regression coverage in `b44e57b9a` and synced the branch with current `dev` (latest head `63500bb03`). The new `testReplayKeepsTombstoneForSameKeyAndTimestamp` writes a value followed by a tombstone for the same key and exact timestamp through the real `WALWriter`, then replays through `WALReader`. It verifies both recovery APIs: - `loadAllData` does not restore the deleted key; - `loadAllKeys` does not expose the deleted key. The test uses an isolated WAL directory and cleans it up after the suite. Verification: - focused `WALReaderAndWriterTest`: 2 tests, 0 failures/errors; - full `imap-storage-file` module: 14 tests, 0 failures/errors, 1 credential-dependent OSS test skipped; - Spotless passed as part of Maven `verify`. Could you please re-review the latest head? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
