fatmanverse commented on PR #11487: URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-5042615015
Thanks for the recheck. I have rebased this PR onto the latest dev and resolved the documentation conflicts while preserving the snapshot, specific/GTID, and enable_concurrent_read documentation. The branch is now up to date with dev. I also fixed the snapshot-only E2E failure. The test previously updated the primary key from id=5 to id=6 while later snapshot splits were still pending. Flink 1.18 could legitimately read id=6 from a later snapshot split, so this did not indicate that the source had entered continuous binlog streaming. The test now only deletes id=2 from an already completed split, which keeps the intended assertion without moving a row into a pending snapshot range. The latest dev also introduced Container.ExecResult usages in MysqlCDCSpecificStartingOffsetIT without importing org.testcontainers.containers.Container, which blocked compilation of the whole MySQL CDC E2E module. I added the missing import. Local verification completed: - ./mvnw spotless:apply - 18 related CDC unit tests passed - MysqlCDCSnapshotOnlyIT passed on all 5 PR runtimes: Flink 1.13, 1.15, 1.18, 1.20, and Zeta (5 tests, 0 failures, 0 errors) - ./mvnw -q -DskipTests -Dskip.ui=true verify passed The original full verify without skip.ui was also attempted locally, but the unchanged seatunnel-engine-ui npm install exited with code 243, so the successful full backend verification explicitly skipped UI. The updated head is 012fbd1281a278580e3be7a53b43ea0afd28b751. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
