SEZ9 commented on PR #11509: URL: https://github.com/apache/seatunnel/pull/11509#issuecomment-5055003130
@SEZ9 Thanks for the thorough re-review — all five items addressed in the new head `8af568a`: **1. Rejection detection now uses the structured botocore error code.** `_is_temperature_rejection` requires `isinstance(error, botocore.exceptions.ClientError)` and `e.response["Error"]["Code"] == "ValidationException"`; the message is only used to discriminate that `temperature` is the rejected parameter (tolerant to wording changes like "deprecated" vs "not supported"). The `except Exception` clauses in `chat`/`chat_stream` are narrowed to `ClientError`. Tests assert that a ValidationException with a different message, a ThrottlingException mentioning "temperature", and a plain RuntimeError all propagate untouched without caching the model. **2. User-facing changes documented.** README now documents (a) the Bedrock temperature fallback under Provider Configuration → AWS Bedrock (including that a configured temperature is not applied for these models), and (b) the field-aware placeholder exemption table under Validation Pipeline, referencing the LocalFile sink docs. The commit message also describes the full `partition_dir_expression` behavior. **3. `chat_stream` retry covered.** `tests/test_llm_provider_bedrock.py` adds stream-path tests mirroring the chat tests: rejection → retry without temperature → cached skip on the next call, plus a non-temperature error case that propagates. **4. HOCON colon separator supported.** `field_pattern` accepts both `key = value` and `key : value`; regression tests cover accepted engine placeholders and rejected env vars in colon syntax. **5. Tests split by module.** Bedrock provider tests moved to `tests/test_llm_provider_bedrock.py` (ASF header included); `test_validate_hocon_placeholders.py` now contains only validate_hocon cases. Full suite: 45 passed. Head remains rebased on current dev. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
