SEZ9 commented on PR #11413: URL: https://github.com/apache/seatunnel/pull/11413#issuecomment-5077822452
Thanks everyone for the follow-ups — replying to the open points: **On the `BatchBuffer` API concern (@DanielLeens):** Fair pushback, and I agree. Since `BatchBuffer.add(...)` is only consumed by `HugeGraphSinkWriter` within the same connector and isn't part of `seatunnel-api` or any engine/SPI contract, I'm withdrawing this as a merge blocker. That said, reducing the visibility of that helper (e.g., package-private) would be a good cleanup — either in this PR or a small follow-up, your call. **On the ordering fixes (@zhupitertop):** Thanks for enforcing the Vertex → Edge order on upsert/flush and Edge → Vertex on delete, and especially for adding E2E coverage for the mapping-order and `delete_vertex_with_edges` cases — those were exactly the scenarios I'd want tested. **On the merge strategy question:** Given the PR has already been reviewed end-to-end and the pieces (source connector, sink refactor, tests/docs) are tightly coupled, I'm OK reviewing and merging it as a single PR at this point. Splitting now would likely cost more than it saves. For future contributions of this size, separate PRs per logical unit would be preferred. **Remaining asks before merge:** 1. Address @nzw921rx's doc comments: add a frontmatter title (`--- title: HugeGraph ---`) to the new doc and drop the changelog section from the top of the user guide. 2. Move the unrelated doc fix flagged by @nzw921rx into a separate PR to keep this one scoped. 3. Sync with the latest `dev` and rerun `Build`, as @DanielLeens suggested. If anything still fails, please post the failing check link so we can confirm whether it's related to the HugeGraph changes. Once those are done I'll do a final pass. Thanks for the patience on a big one! <!-- streview-comment:2 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
