DanielLeens commented on PR #11069: URL: https://github.com/apache/seatunnel/pull/11069#issuecomment-5082449317
Hi @lazyfetch, thanks again for contributing this fix and for patiently following up on the CI state. I rechecked this against the current branch today before trying to resolve the conflict. The PostgreSQL CDC capability is now already covered on by the later merged #10724. The current implementation has the branch wired to and includes broader parsing coverage for ISO offsets, IANA zone ids, space-separated datetime strings, short hour-only offsets, UTC literals, plus the invalid-format path. That is a superset of the older implementation in this PR. Because this PR is now conflicting with that newer implementation, merging it would no longer be the right rescue path and could accidentally regress the current converter behavior. I am closing this one as already covered by the newer merged implementation, not because the original direction was wrong. The contribution was useful and helped push this area forward. Please keep contributing when you spot CDC type gaps like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
