DanielLeens commented on PR #10897: URL: https://github.com/apache/seatunnel/pull/10897#issuecomment-5083457565
Hi @chl-wxp, thank you for looking closely at the JDBC upsert configuration and for trying to simplify the connector surface. Reducing unnecessary options is a worthwhile goal when compatibility permits it. After reviewing the current `dev` behavior, `support_upsert_by_insert_only` is still part of the public configuration contract, is documented and tested, and is also involved in the Oracle insert-mode behavior. Removing it directly would break backward compatibility for existing jobs, so this PR cannot safely move forward in its current direction. We are closing this PR, but the discussion is still useful. If the option should eventually be deprecated, a fresh proposal with a compatibility period, migration guidance, and an incompatible-change plan would be welcome. Thank you for raising the question and helping us examine the contract carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
