DanielLeens commented on PR #11290:
URL: https://github.com/apache/seatunnel/pull/11290#issuecomment-5086985200
Thanks for the detailed review. I addressed the remaining items on the
latest head.
One clarification on Issue 1: the required PR `Build` is not produced by
running `backend.yml` directly on an Apache `pull_request` event.
`build_main.yml` runs on `push` in the PR head repository, and
`notify_test_workflow.yml` maps that head-repository run back to the Apache PR.
For the usual fork PR, `GITHUB_REPOSITORY_OWNER` is therefore the fork owner
and `GITHUB_BASE_REF` is empty. Forcing full coverage from the PR target branch
would require a separate PR lookup and would undo the intended changed-file
scoping for lightweight fork pushes. The `${GITHUB_BASE_REF:-$GITHUB_REF}`
handling remains in place for any caller that actually invokes the reusable
workflow from a pull-request context.
The latest update also:
- documents this head-repository push and check-mapping model in both
English and Chinese
- lists the exact protected Apache push branches and lightweight path
allowlist
- explains connector changed-module IT routing, engine routing, and that the
selected unit-test job still verifies all modules
- adds regression cases for `main`, `master`, two- and three-component
release branches, `hotfix-release`, and release tags, in addition to the
existing bare-base and merge-ref cases
- keeps helper failures and invalid output fail-safe to full API coverage
The latest `Build` exercises these tests in the Code style job and confirms
that the unrelated connector/JDBC/Kafka matrices are skipped for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
