DanielLeens commented on PR #10532: URL: https://github.com/apache/seatunnel/pull/10532#issuecomment-5092881763
Thanks for the detailed update — that direction makes sense to me. I checked the current head `a4072859`, and it still includes `AbstractJdbcCatalog.java` and `AbstractJdbcCatalogCloseTest.java`, so I cannot mark that part resolved yet from the current code snapshot.\n\nPlease push the cleanup commit that drops the duplicated JDBC catalog part and keeps the remaining file read-strategy resource fix. After that new head is available, I will re-review the full diff again. Since the current `Build` result is from the old head and the branch is quite far behind `dev`, rerunning CI on the cleaned-up/latest head will give us a much more useful signal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
