SEZ9 commented on PR #11548: URL: https://github.com/apache/seatunnel/pull/11548#issuecomment-5094161843
All six findings addressed in head `d234eeb`: 1. **Dependency floor**: `bedrock-mantle` extra now requires `openai>=2.45.0`; the `dev` extra gains `aws-bedrock-token-generator` so mantle tests run in dev installs. 2. **CLI selection/routing**: `--provider` accepts `bedrock-mantle`; `--model`/`--fast-model` and config.json overrides now route OpenAI-protocol providers (`openai`, `bedrock-mantle`) to `OPENAI_MODEL*` — previously a mantle `--model` was silently written to `ANTHROPIC_MODEL` and ignored. New `tests/test_cli_provider_routing.py` covers both families and unknown-provider rejection. 3. **Reasoning replay**: reasoning output items are preserved verbatim in internal history as opaque `mantleResponsesItem` blocks (both chat paths, wired through `collect_stream`) and replayed in order on the next turn. Verified against the live endpoint: reasoning + function_call + result round-trip completes with the reasoning item echoed back. 4. **store=False**: sent on every request in both paths, with tests asserting the flag and a README note explaining the retention default it avoids. 5. **Terminal states**: non-completed statuses (with `incomplete_details`/`error` context), refusal content parts, and `response.failed`/`incomplete`/`error` stream events now raise `RuntimeError` — truncated output can no longer surface as a successful `end_turn`. Covered by tests for incomplete status, refusal, and stream failure. 6. **Docs/tests**: docstrings on `_get_client`/`chat`/`chat_stream` contracts; 10 new tests (17 total for this provider). Website docs for the AI CLI (including this provider) landed separately in #11551. Scope note: kept strictly to the six findings — no provider-registry refactor or unrelated cleanup. Full suite: 56 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
