DanielLeens commented on PR #10961: URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-5120218944
Hi @PZh101, thanks again for contributing the KingbaseES MySQL compatibility work. This is a useful improvement, and I did not want it to get stuck just because the branch had drifted behind `apache/dev`. I have updated this original PR branch directly: - Merged the latest `apache/dev` into the PR branch. - Resolved the `KingbaseDialect` conflict by keeping both sides of the current behavior: the newer Kingbase `table_options` validation from `dev`, and this PR's MySQL compatibility-mode routing for row conversion, type mapping, and upsert SQL. - Kept the MySQL dialect implementation untouched, so the change remains scoped to Kingbase/JDBC integration. - Ran scoped formatting: `./mvnw -nsu -Dmaven.gitcommitid.skip=true -pl seatunnel-connectors-v2/connector-jdbc spotless:apply`. The PR now points to head `a0146d1748f66eda6f39687176dd07c1744f764f`, and GitHub reports it as mergeable again. The remaining gates are the normal GitHub CI/review checks. Appreciate the original work here — the community can continue from the same PR thread instead of losing the context. 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
