SEZ9 commented on issue #11620: URL: https://github.com/apache/seatunnel/issues/11620#issuecomment-5155771482
Confirmed mismatch: PulsarBaseOptions.FORMAT and PulsarSourceFactory OptionRule advertise text format, but PulsarMultiTableConfig.validateFormat() only allows JSON/CANAL_JSON/AVRO and PulsarSource.createDeserialization() has no TEXT branch. Preferred fix is to add TEXT support to the source using TextDeserializationSchema (seatunnel-format-text is already a dependency, and the sink already supports text). This should include adding TEXT to validateFormat(), a TEXT branch in createDeserialization() honoring field_delimiter, and an e2e/unit test. If text support is intentionally not planned for the source, the alternative is to remove text from the option description, the OptionRule conditional binding, and the source docs to keep the contract consistent. Please indicate which direction you'd like; a PR is welcome either way. <!-- streview-comment:31 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
