DanielLeens commented on PR #11198: URL: https://github.com/apache/seatunnel/pull/11198#issuecomment-5174445191
Thanks for splitting the CI change out into #11636 — that is exactly the right direction, and I appreciate the quick turnaround. Two things to make this PR ready for the next round: 1. The blocker on this head is still that the shared `.github/workflows/backend.yml` edits are bundled inside this connector PR. Now that #11636 exists to carry the workflow discussion, could you push an update here that reverts the `backend.yml` changes from this branch, so the PR stays scoped to the Couchbase connector? Once that commit is up, I will re-review the full head from scratch. 2. One honest heads-up on #11636 so it does not become a surprise later: in my review over there, the `-DargLine` heap setting as currently written is not consumed by the root backend test path, so as-is it will not deliver the intended memory increase — it needs to be wired through the root Surefire/Failsafe configuration first. So I would not treat #11636 as a guaranteed fix for the `all-connectors-it-3` cancellation yet; keeping that work out of this connector PR is still correct either way. The connector-side source points look addressed on the current head, so this is genuinely close. Happy to do the full re-review as soon as the descoped commit lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
