DanielLeens commented on issue #11638: URL: https://github.com/apache/seatunnel/issues/11638#issuecomment-5178794563
Thanks for doing the repo audit. I checked the current `dev` tree as well, and the scope you listed matches what is actually wired today: 1. the shared `tyrantlucifer/*` image references that affect Apple Silicon local E2E are concentrated in `seatunnel-e2e-common`, especially `Spark2Container`, `Spark3Container`, and the shared Flink 1.13/1.14/1.15/1.16/1.17/1.18/1.20 container classes; 2. I do not see repo-owned Dockerfiles for those shared E2E images under `seatunnel-e2e` today; 3. the repo already has project Docker publishing infrastructure in `.github/workflows/publish-docker.yaml`, including QEMU + Buildx for multi-arch publishing, so I would prefer the replacement path to stay project-owned rather than move to another personal namespace. Given that, I agree with your proposed first slice: - start with the two shared Spark images first, because that covers both shared Spark environments with the smallest image count; - add the Dockerfiles / build metadata in-repo near the shared `seatunnel-e2e-common` container layer, since that is where the current image references live; - keep the first PR focused on one native ARM64 proof point plus the `Spark2Container` / `Spark3Container` updates, instead of trying to rebuild every Flink tag at once. I would not block you on the exact final publish destination before opening the PR. Please open a focused PR with: 1. the in-repo build context for the Spark images; 2. the Java container updates for `Spark2Container` and `Spark3Container`; 3. a short note in the PR description about the desired project-owned publish destination and which remaining Flink images are intentionally left for follow-up. That should be a reviewable first step for this issue, and we can keep the remaining Flink image set as follow-up work once the Spark path is proven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
