DanielLeens commented on issue #11650:
URL: https://github.com/apache/seatunnel/issues/11650#issuecomment-5186334723

   Thanks for separating these two CLI defects and for opening PR #11652 so 
quickly.
   
   I checked the behavior described here against the current CLI fallback path, 
and this does look like a real bug rather than only a prompt-quality problem. 
When runtime metadata is missing, the CLI should not silently behave as if 
SeaTunnel has zero connectors, and the not-found suggestion path should never 
echo the queried connector name back to the user.
   
   The important acceptance points here are:
   1. missing runtime metadata degrades visibly and still preserves useful 
connector-name guidance;
   2. a known connector without metadata is not misreported as "not found";
   3. an actually unknown connector name gets meaningful suggestions that do 
not include the original query itself.
   
   PR #11652 is the right place to finish the code review. Please keep the 
change boundary focused on the fallback/diagnostic path, and add focused 
coverage for both cases: a known connector with no metadata file, and a 
genuinely unknown connector name. Keeping this issue open until #11652 is 
reviewed and merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to