DanielLeens commented on PR #11636:
URL: https://github.com/apache/seatunnel/pull/11636#issuecomment-5190598117
Thanks @davidzollo for the +1.
Since the condition was "if CI passes": on this same head (`36e92bc6`), the
`Build` check is currently showing `fail`, not pending anymore. That lines up
with what I flagged as Issue 1 in my review above — `${argLine}` has no default
anywhere in this repository, so the placeholder stays unresolved in roughly 54
of the ~55 Maven invocations in `backend.yml` (everything except the one
`unit-test` line this PR itself edits) plus every local `./mvnw test`/`verify`.
That's a repository-wide build break riding on what the PR title describes as a
scoped CI-only change, and I'd expect it to be visible in the CI run right now.
@srijan-singh, my Issue 1 and Issue 2 (unsafe `-DargLine="..."` quoting on
the Windows leg of the same job) from the review above are still the two
blockers — the fix is small (a defaulted `surefire.jvm.args`-style property
following the existing pattern in `connector-lance/pom.xml:40,120`, plus moving
the value into `env:` for the Windows quoting issue). Once that's in and
`Build` is green on the new head, I'm glad to do a full re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
