DanielLeens commented on issue #11632: URL: https://github.com/apache/seatunnel/issues/11632#issuecomment-5199226387
Thanks for linking PR #11633 and for spelling out the design choices so clearly. The scoping here makes sense to me: 1. for this issue, applying `defaultValue` to both a missing field and an explicit JSON `null` is consistent with the acceptance criteria you documented; 2. keeping the first fix limited to `seatunnel-format-json` is the right tradeoff for reviewability; 3. treating the cross-format default-value gap as follow-up work avoids mixing a bug fix with a broader refactor. The issue can stay open for tracking, but the technical discussion should now continue primarily on PR #11633. From the issue side, the remaining acceptance bar is straightforward: the current PR head needs to keep the missing-field and explicit-null behavior covered, avoid regressions for the no-default case, and reach terminal green CI before we treat this as resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
