DanielCarter-stack opened a new pull request, #11687:
URL: https://github.com/apache/seatunnel/pull/11687

   ## Purpose of this PR
   
   The Databend source and sink documentation had several gaps and 
inconsistencies compared with the connector code and the conventions used 
across the connector-v2 docs. This PR cleans them up based on the connector 
code (`DatabendSourceFactory`, `DatabendSinkFactory`, `DatabendSinkConfig`) and 
the connector e2e examples.
   
   ## Changes
   
   - **Section headings & feature labels**: Standardized the `## Support Those 
Engines` and `## Supported DataSource Info` headings, and switched the EN Key 
Feature labels to the canonical lowercase forms used across connector-v2 docs 
(`batch`, `stream`, `exactly-once`, `cdc`, `parallelism`, `support user-defined 
split`, `support multiple table read` / `support multiple table write`, `timer 
flush`). The `[x]`/`[ ]` markings are unchanged and match the implementation 
(e.g. exactly-once via the sink's two-phase committer, CDC via 
`conflict_key`/`enable_delete`, no multi-table write).
   - **Supported DataSource Info**: Fixed the malformed source table (empty 
`Driver`/`URL`/`Maven` columns) and added the missing sink section, both with 
the standard `Datasource | Supported Versions | Dependency` shape and the 
`connector-databend` Maven download link.
   - **common-options**: Added the missing `common-options` rows to the source 
and sink option tables, linking to the common-options docs.
   - **CDC example**: Expanded the sink CDC example from a sink-only snippet 
into an end-to-end flow that emits 
`INSERT`/`UPDATE_BEFORE`/`UPDATE_AFTER`/`DELETE` row kinds, demonstrating 
`conflict_key` merge and `enable_delete` behavior.
   - **fetch_size**: Noted that `fetch_size = 0` falls back to the JDBC driver 
default, matching the option description in code.
   
   ## Notes
   
   - Both EN and ZH (`docs/en/connectors/{source,sink}/Databend.md` and 
`docs/zh/connectors/{source,sink}/Databend.md`) are updated and kept consistent.
   - The option list was verified against the connector `OptionRule` and 
`DatabendSinkConfig` (including the CDC-only `conflict_key` / `enable_delete` 
options that are read from config).
   - Documentation only; no code or version numbers were changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to