zhengxiang378928908-code commented on PR #11684: URL: https://github.com/apache/seatunnel/pull/11684#issuecomment-5214091560
Correcting something in my own PR description. I originally wrote that no E2E test was added because there is no Dameng E2E suite and no publicly available test image. That was wrong. `JdbcDmIT` already exists in `connector-jdbc-e2e-part-5` and runs against the public `laglangyue/dmdb8` image, and its `CREATE_SQL` even covers `VARCHAR2` — it just has no `NVARCHAR`/`NCHAR`/`NVARCHAR2` column, which is very likely why this gap went unnoticed. I had based that statement on a search of my own that was too narrow to find the file, and I should have verified before claiming the suite did not exist. I've pushed E2E coverage and rewritten that section of the description: - `DM_NVARCHAR2 NVARCHAR2(50)` added to `JdbcDmIT`, with the matching `fieldNames` entry, row value and the explicit insert column list in `jdbc_dm_source_and_sink.conf` - the column is populated with multi-byte content so the national character path is actually exercised - insert columns, placeholders, `fieldNames` and the row array are consistent at 34 entries - `JdbcDmUpsetIT` declares its own table and is unaffected One thing I want to be explicit about: I could not run this suite locally because Docker is unavailable in my environment, so the container path is validated by CI rather than by me. `./mvnw test-compile` on `connector-jdbc-e2e-part-5` passes. The code change and the unit test are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
