zhengxiang378928908-code commented on PR #11689: URL: https://github.com/apache/seatunnel/pull/11689#issuecomment-5214331229
Closing this in favour of #11684. Both PRs fixed missing Dameng national character types, and they overlapped in the same `JdbcDmIT` table and insert column list, so whichever merged second would have needed a rebase. Since `NCHAR` and `NVARCHAR2` are the same gap in the same type family and the same converter, keeping them apart added review overhead without buying anything. #11684 now covers `NVARCHAR` (unchanged), `NVARCHAR2` and `NCHAR` together, and closes both #10635 and #11688. The `NCHAR` change is carried over unmodified — same converter case, same unit test, same E2E column. Sorry for the churn; I should have scoped it that way from the start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
