CBOSSX opened a new pull request, #11693:
URL: https://github.com/apache/seatunnel/pull/11693

   ### Purpose of this pull request
   
   Closes #11688.
   
   Dameng `NCHAR` columns currently fall through `DmdbTypeConverter`'s 
unsupported-type branch because only `NVARCHAR` is enumerated. This adds the 
missing `NCHAR` mapping to SeaTunnel `STRING`, preserves the concrete source 
type, and adds regression coverage.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Dameng `NCHAR` source columns that previously failed schema conversion 
with `COMMON-17` are now mapped to SeaTunnel `STRING`. The English and Chinese 
JDBC source documentation describe the mapping.
   
   ### How was this patch tested?
   
   The new regression test failed on the unchanged base with:
   
   ```text
   ErrorCode:[COMMON-17], ErrorDescription:['Dameng' unsupported convert type 
'nchar' of 'test' to SeaTunnel data type.]
   ```
   
   It passes after the fix. The following checks also pass:
   
   ```bash
   ./mvnw test -pl seatunnel-connectors-v2/connector-jdbc 
'-Dtest=DmdbTypeConverterTest#testConvertNchar' -Dskip.spotless=true
   ./mvnw test -pl seatunnel-connectors-v2/connector-jdbc 
'-Dtest=DmdbTypeConverterTest' -Dskip.spotless=true
   ./mvnw spotless:check
   ./mvnw -DskipTests verify
   ```
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] The English and Chinese JDBC connector documentation is updated.
   * [x] No incompatible change is introduced, so `incompatible-changes.md` 
does not need an update.
   * [x] No new connector registration is introduced, so plugin mapping, 
distribution POM, CI label scope, E2E registration, and `plugin_config` do not 
need updates.
   
   ### Scope
   
   * 4 files changed, +22 / -1 lines.
   * No dependency, generated, vendored, or public API changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to