SEZ9 commented on issue #11685: URL: https://github.com/apache/seatunnel/issues/11685#issuecomment-5225135488
Confirmed: YashanDbTypeConverter.convert() handles CHAR/VARCHAR and NCHAR/NVARCHAR but not the VARCHAR2/NVARCHAR2 synonyms that YashanDbCatalog#SELECT_COLUMNS_SQL explicitly queries for. Fix should add VARCHAR2 to the byte-length (VARCHAR) branch and NVARCHAR2 to the char-length (NVARCHAR) branch, consistent with the catalog's length semantics. Please also check the reverse direction (reconvert) so sink-side DDL generation emits a type YashanDB accepts, and add unit tests in YashanDbTypeConverterTest covering VARCHAR2/NVARCHAR2 with and without length. The reporter provided a converter-level reproduction that requires no server; would you like to submit a PR? This looks like a small, well-scoped change in YashanDbTypeConverter plus tests. <!-- streview-comment:75 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
