DanielLeens commented on PR #11675: URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5229131017
Hi @ClaireLytt, thanks for flagging this — I dug into the actual CI runs for the current head (a33a9ba) on both attempts before replying, rather than going off the check summary alone. Good news: I don't see any real CheckpointPlanTest / TaskTest failures for this PR. Specifically: - Attempt 1 (finished 2026-08-07 12:48 UTC): in the `unit-test (8, ubuntu-latest)` job log, `org.apache.seatunnel.engine.server.checkpoint.CheckpointPlanTest` ran with `Tests run: 1, Failures: 0, Errors: 0`, and `org.apache.seatunnel.engine.server.dag.TaskTest` ran with `Tests run: 3, Failures: 0, Errors: 0`. Both are clean passes through the `AbstractSeaTunnelServerTest` Hazelcast setup, no errors in `before()` or anywhere else. - The only non-passing job in attempt 1 was `unit-test (11, windows-latest)`, which failed — but that's unrelated to Checkpoint/Task tests too. - Attempt 2 (the rerun, finished 2026-08-08 08:07 UTC) is fully green on every unit-test job, including `unit-test (11, windows-latest)`, which passed on retry — consistent with that being a flaky/transient failure rather than anything real. The one job that is still not green in either attempt is `Run / Build website` (the docusaurus docs-site build), which hangs for well over an hour and then gets cancelled — that's what's making the overall `Build` check on the apache side show as failed/cancelled. That's unrelated to the Hazelcast/engine test setup and unrelated to the Iceberg connector code in this PR; it looks like an infra/docs-build flakiness issue on the CI side, not something introduced by your change. So from my side there's nothing in `CheckpointPlanTest`/`TaskTest`/`AbstractSeaTunnelServerTest` that needs fixing here, and it doesn't block this PR. If you're still seeing those specific test failures locally or in a different run, could you share the run URL or the actual failure stack trace? I'm happy to take another look, but I couldn't reproduce or find evidence of that failure in this PR's CI history. My prior approval stands either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
