SEZ9 commented on PR #11550: URL: https://github.com/apache/seatunnel/pull/11550#issuecomment-5230722015
Thanks @SEZ9 for consolidating the checklist — it matches my review exactly, so nothing to add on substance. We now have full reviewer alignment on the core fix: the restore-path pruning is correctly scoped to the captured-table set and is a no-op when the table set is unchanged. To the author, restating the concrete asks so there's one clear list to work from: 1. **Rebase onto latest `dev` and rerun CI first.** The branch is 26 commits behind, so the current `Build` failure on `133ca2cc7298` isn't attributable to this diff yet. If the same lanes stay red after the rebase, post the fresh failing job links and we'll help narrow it down. 2. **Drop the unrelated `docs/en/transforms/llm.md` change** — separate PR, please, so this fix stays focused and backportable. 3. **`checkpointTables` handling:** either filter it consistently with the other three collections, or add a short comment in `pruneRemovedTables()` explaining why it's intentionally passed through unpruned. 4. **Enumerator-side gap:** I'm fine deferring the `HybridPendingSplitsState`/`IncrementalPhaseState` pruning to a follow-up issue rather than growing this PR — but please open that issue (or state here that you'd rather handle it in this PR) so the decision is explicit. Once the branch is rebased, CI is green, and 2–4 are addressed or explicitly deferred, this is mergeable from my side and just needs a committer's approval. Thanks again for the fix and the unit test coverage on the pruning path. <!-- streview-comment:110 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
