DanielLeens commented on PR #11671: URL: https://github.com/apache/seatunnel/pull/11671#issuecomment-5233811086
Thanks @davidzollo! Closing the loop on the "if CI passes" condition: I just checked the Apache-side `Build` check at the current head (`ab49048d5781`) and it's green (passed in ~8h53m, no failing jobs). Combined with the fork's own `benchmark-test` jobs (JDK 8 and 11) that I verified passing on this exact head in my last review, there's no outstanding CI signal blocking this anymore. With both of us at APPROVED and CI fully green on this head, I don't see anything else standing in the way of merging this Phase 1 benchmark framework. Thanks again for the second pair of eyes on the percentile-overflow and Maven-cache findings earlier in the review — both landed clean fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
