DanielLeens commented on issue #11723: URL: https://github.com/apache/seatunnel/issues/11723#issuecomment-5234824397
Thanks for splitting this from #11696 and for calling out that the corruption is in the binary-operator path rather than the scalar-function path fixed by #11697. I checked the reported execution path, and this looks like a real correctness bug. Converting `DECIMAL` operands through `double` defeats the point of exact decimal arithmetic, and using `RoundingMode.UP` for division will bias results away from zero instead of rounding to the nearest expected SQL result. Since you already opened PR #11724, the main review focus now should be exact operand conversion coverage for mixed `DECIMAL` and integral cases, plus whether the division rounding change needs an incompatible-changes note because it changes user-visible results from the current broken behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
