zhangshenghang commented on PR #10306:
URL: https://github.com/apache/seatunnel/pull/10306#issuecomment-5236133495
Thanks @SEZ9. I rechecked the `JdbcSinkWriter` public surface on the current
head `da827df05222` against the current PR merge base.
For `JdbcSinkWriter`, I do not see a removed public/protected signature:
- The existing constructor with `SinkWriter.Context` is still present with
the same parameter list:
`JdbcSinkWriter(TablePath, SinkWriter.Context, JdbcDialect,
JdbcSinkConfig, TableSchema, TableSchema, Integer)`.
- This PR only adds a compatibility overload without `SinkWriter.Context`,
delegating to the original constructor with `null` context.
- Existing public methods are still present:
`initMultiTableResourceManager`, `setMultiTableResourceManager`, `primaryKey`,
`snapshotState(long)`, `write(SeaTunnelRow)`, `prepareCommit()`,
`abortPrepare()`, `close()`, and `timerFlush()`.
- The new `prepareCommit(long)` and `SupportRowLevelErrorClassifier`
implementation are additive.
I also checked call sites in the current source/tests: the production
`JdbcSink` path still calls the original context-aware constructor, and the
no-context overload is only an additional fallback for compatibility/test
construction. So this appears to be backward-compatible at source level; I do
not think a code change is needed for this specific `JdbcSinkWriter` API
concern. The remaining gates from my side are still the current Build attempt
and maintainer approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
