DanielLeens commented on PR #10252: URL: https://github.com/apache/seatunnel/pull/10252#issuecomment-5237307265
Thanks for confirming, and for the two independent passes on this. Good to see we landed on the same root cause from separate directions. To keep the ask list in one place for the author: the blocking item is the missing test scope on the junit-jupiter-api dependency in connector-jdbc/pom.xml, which is leaking a test-only dependency onto the connector's compile/runtime classpath and is very likely also why the Build check is red. Once that scope is added and the branch is rebased on the latest dev so CI can run clean, the remaining points (the static system property mutation in AbstractPostgresContainerTest, the leftover test_catalog_table not being cleaned up, the inert Testcontainers annotation, and the disabled PostgresDialect.parse() quoting test) are all non-blocking follow-ups we can fold in together. Nice migration overall, the move to a real Postgres container for catalog and dialect coverage is a solid improvement over the old string-based assertions. Happy to do a final pass as soon as the scope fix and rebase land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
