waterWang opened a new pull request, #11744:
URL: https://github.com/apache/seatunnel/pull/11744

   ## Description
   
   `ParquetWriteStrategy#getOrCreateOutputStream` registers three Avro 
logical-type conversions on the data model. The third one 
(`LocalTimestampMillisConversion`) is unreachable.
   
   ### Analysis
   
   1. `seaTunnelDataType2ParquetDataType` maps TIMESTAMP to 
`INT64.as(OriginalType.TIMESTAMP_MILLIS)`, which parquet-avro's 
`AvroSchemaConverter` converts to Avro's `timestamp-millis` logical type — NOT 
`local-timestamp-millis`.
   
   2. `resolveObject` handles TIMESTAMP values manually (converting to epoch 
millis via `LocalDateTime.toEpochMilli()`), bypassing the data model's 
conversion entirely.
   
   Therefore, `TimeConversions.LocalTimestampMillisConversion` is never invoked 
on any code path through this class.
   
   ### What changed
   
   - Removed the `LocalTimestampMillisConversion` registration
   - Added a comment explaining why it's not needed
   
   ### Related issue
   
   Closes #11743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to