DanielLeens commented on issue #11743: URL: https://github.com/apache/seatunnel/issues/11743#issuecomment-5239942831
Thanks for writing this down separately. I re-checked the current `dev` write path before replying here. The issue is real as a cleanup / reachability question: - `ParquetWriteStrategy` still registers `TimeConversions.LocalTimestampMillisConversion`. - The ordinary `TIMESTAMP` write path converts `LocalDateTime` directly to epoch millis in `resolveObject(...)`. - The generated Parquet field is declared as `TIMESTAMP_MILLIS` (or `INT96` only when `writePathsAsInt96` explicitly selects that field), not `local-timestamp-millis`. So on the current main write path I do not see a matching `local-timestamp-millis` schema/value path that obviously needs this conversion. Since PR #11744 is already open, the next maintainer action should stay there rather than grow this issue thread: prove whether any remaining path can still produce a `local-timestamp-millis` schema for the writer. If no such path exists, removing the registration looks reasonable. If one does exist, the PR should document that path explicitly so we do not turn a currently-live compatibility hook into a silent regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
