DanielLeens commented on issue #11741: URL: https://github.com/apache/seatunnel/issues/11741#issuecomment-5239945139
Thanks for splitting the JDBC-source side out separately. I re-checked current `dev`, and this is a real `connector-jdbc` gap, not just the CDC issue restated: - `ChunkSplitter.findSplitKey()` still returns the first supported PK column only. - `DynamicChunkSplitter` still operates on one `splitColumnName` and one `splitColumnType`. - `JdbcDialect.queryNextChunkMax(...)` is still a single-column boundary walk. So keeping this as a separate JDBC issue from MySQL CDC (#11742) is the right boundary. For a first PR, I would keep the scope tight inside `connector-jdbc`: - multi-column split-key selection for composite PK tables; - tuple-ordered boundary walking for the JDBC splitter itself; - regression coverage proving the current single-column numeric / string / date paths stay unchanged. I would avoid widening the first patch into CDC-base or cross-module unification unless the JDBC implementation itself needs it. Getting the `connector-jdbc` contract correct first will make later reuse much easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
