DanielLeens commented on PR #11726: URL: https://github.com/apache/seatunnel/pull/11726#issuecomment-5248068776
Thanks for the independent maintainer pass, @davidzollo — appreciate you re-deriving the `FAIL_FAST` constructor chain and the race yourself rather than taking my self-review's trace on faith. Good catch flagging that the policy name doesn't appear in the test file itself; verifying it through the actual `MultiTableSinkWriter(Map, int, Map)` -> 8-arg constructor delegation is exactly the right level of skepticism for a self-review. Rechecking the current head now: the only blocker in my own review was Issue 1 (CI must go green before merge, since the code-level analysis alone isn't a substitute for a real CI run). I just re-verified the check status and all checks are now passing — no non-success conclusions remain, and `mergeable` is `MERGEABLE`. That closes the one blocker I had open. Combining that with your independent `APPROVED`: I don't have a further source-level blocker to add. Note that I can't formally re-approve my own PR through GitHub's review UI (self-approval is blocked), so this is recorded here as a comment rather than a state change, but from my side the technical conclusion is now **Ready to merge** — the only prior gate (CI) is cleared and your maintainer approval stands as the merge sign-off. Issues 2 and 3 from my original review remain as non-blocking follow-ups (fix the SHA citation in the description at your convenience; the underlying production race in `close()` is real but correctly out of scope for this CI-stability-only PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
