nzw921rx commented on PR #11574: URL: https://github.com/apache/seatunnel/pull/11574#issuecomment-5249446017
### Post-merge impact and downstream sync assessment I checked this PR against the current `dev` head (`3678ae3d6095`) and scanned all currently open PRs that modify `seatunnel-e2e`. #### Safety of merging this PR now - The branch is **7 commits ahead / 4 commits behind** current `dev`. - The 4 commits added to `dev` after this PR baseline modify **0 files under `seatunnel-e2e/`**. They are documentation, Core validation, and CLI changes, so there is no uncovered E2E baseline change. - GitHub currently reports `mergeable=true`. The `blocked` state is caused by checks/review requirements, not a merge conflict. - Scope is test infrastructure only: 103 E2E files, replacing fixed host bindings with dynamic mappings. Container-network service ports such as `mysql-e2e:3306` remain unchanged. - The full fork workflow for this branch completed without failed or cancelled jobs: https://github.com/nzw921rx/seatunnel/actions/runs/31382608165 **Risk to `dev`: low.** This change removes shared host-port collisions and does not change production runtime behavior. Merging it does not require all older PRs to update first; affected downstream PRs must sync before their own merge. #### PRs that genuinely need to sync after this PR merges | PR | Behind current `dev` | Why sync is needed | | --- | ---: | --- | | #11572 | 4 | 22 directly overlapping E2E files and the same old baseline as this PR. Combined CI should run after syncing. | | #11626 | 12 | Changes `SeaTunnelContainer` and shared container reuse/lifecycle classes. | | #11648 | 17 | Changes `SeaTunnelContainer` plus four directly overlapping E2E files. | | #11545 | 21 | Changes shared Flink container classes and `SeaTunnelContainer`. | | #11390 | 36 | Changes `AbstractTestFlinkContainer` and `Flink20Container`, including the area where Flink REST port 8081 becomes dynamic. | | #11198 | 0 | Currently based on current `dev`, but changes `SeaTunnelContainer`; it should sync once this PR is merged. | | #11700 | 13 | Changes the same HANA and OpenGauss container setup files. | | #11643 | 21 | Changes `HiveIT`, which is also updated for dynamic Hive endpoints here. | | #11577 | 52 | Changes the same BigQuery endpoint setup and configuration. | | #11556 | 36 | Changes the same PostgreSQL/OpenGauss CDC container setup. | | #11644 | 21 | Changes `PostgresCDCIT`; sync is needed to preserve both the timeout stabilization and dynamic endpoint changes. | Other PRs that only add tests using fixed **container-internal** service ports do not need a special port migration. They only need the normal latest-`dev` refresh before merge. #### Fixed host bindings that must be changed in downstream PRs Across 74 other open E2E PRs, only the following still add fixed host-binding APIs: - #10340: `JdbcOscarIT` / `JdbcOscarUpsetIT` use `setPortBindings`, including `2003:2003`. - #10838: `DynamicMetadataProviderIT` fixes `5801:5801` and `8080:8080`. - #11012: `JdbcSybaseIT` uses `setPortBindings`. - #9976 and #10858 contain multiple inherited fixed mappings and very large branch-history diffs. These PRs need code adaptation in addition to syncing. They are downstream issues and do not make merging this PR risky. #### Older PRs with existing baseline/conflict issues - #11238 is 227 commits behind and already `dirty` against current `dev`. - #11023 is 146 commits behind and already `dirty`. - #10340 is 656 commits behind and already `dirty`. - #10838 is 363 commits behind and already `dirty`. Those PRs already require their own baseline sync regardless of this change. Any conflict after this PR merges is therefore an existing stale-branch issue, not a regression or risk to `dev`. For #10306 specifically: it is 7 commits behind and currently mergeable. Its `mysql-e2e:3306` usage is a container-network address, not a fixed host binding, so it has no dynamic-port compatibility problem. It may refresh `dev` for normal merge freshness, but it is not a blocker for this PR. **Conclusion:** #11574 is safe to merge on the current `dev` baseline. The only follow-up requirement is that PRs modifying shared E2E container infrastructure or the same endpoint setup sync after this merge; stale/conflicting PRs remain responsible for updating themselves before they are merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
