DanielLeens commented on issue #11765:
URL: https://github.com/apache/seatunnel/issues/11765#issuecomment-5253001286

   Thanks for the clear reproducer and the linked fix PR #11766.
   
   I re-checked the current `dev` path in `FlowControlGate.audit()` before 
replying here. It still calls `RateLimiter.acquire(row.getBytesSize())` 
directly, and `SeaTunnelRow.getBytesSize()` can legitimately return `0` for an 
all-null or all-empty row. Since Guava requires a positive permit count, that 
turns a valid data row into a task failure instead of a throttling decision.
   
   So this is a real bug in the current byte-rate limiting path, and treating 
zero-byte rows as consuming zero byte budget while still letting the count 
limiter apply is the right fix direction. The focused regression coverage in 
#11766 for null-only and empty-string rows is also the right shape. Keeping 
this issue open until #11766 lands is the right next step.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to