goutamadwant commented on PR #11541: URL: https://github.com/apache/seatunnel/pull/11541#issuecomment-5276310586
@fatmanverse reviewed the latest changes against the Kafka transaction and checkpoint lifecycle. The flush before reading txnStarted addresses the reported first record race. Async send failures are also retained per transaction and checked before commit, while the empty transaction path remains unchanged. One small documentation point suggestion: saying both errors abort the transaction is not fully accurate for every engine. It may be better to say they fail the checkpoint and prevent the transaction from being committed, then records are replayed from the last completed checkpoint after recovery. No code correctness blocker from my review. Thanks for the changes and contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
