DanielLeens commented on PR #11824: URL: https://github.com/apache/seatunnel/pull/11824#issuecomment-5312548543
Thanks @nzw921rx for the +1! Following up on the CI-pass condition: since my earlier review the `Build` check has moved out of `QUEUED` and completed, currently reporting failure. I checked both the apache-side check and the corgy-w fork run (head `c2a92752438ed685ba596bea97ce65bbe4528522`) to see whether it relates to this revert. Of the ~80 CI jobs, only two failed, each with a single unrelated test error: - `all-connectors-it-1 (11, ubuntu-latest)`: one error in `org.apache.seatunnel.e2e.connector.couchbase.CouchbaseIT` (Tests run: 1, Errors: 1) — https://github.com/corgy-w/seatunnel/actions/runs/31930626737/job/95125029790 - `all-connectors-it-6 (8, ubuntu-latest)`: one error in `org.apache.seatunnel.connectors.seatunnel.cassandra.CassandraIT` (Tests run: 14, Errors: 1) — https://github.com/corgy-w/seatunnel/actions/runs/31930626737/job/95125029839 Neither touches Doris, `thrift-service`, or `seatunnel-shade` — the diff is still just the single `thrift-service.version` property line. `doris-connector-it` passed cleanly on both JDK 8 and 11. This looks like pre-existing flakiness in the Couchbase/Cassandra container-based ITs rather than anything caused by the revert. I'd still recommend rerunning the two failed jobs to confirm before merging, but from a code standpoint this doesn't change my ready-to-merge assessment — the CI-pass condition just needs a clean rerun, not any code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
