davidzollo commented on PR #10499: URL: https://github.com/apache/seatunnel/pull/10499#issuecomment-5317357493
@onceMisery — an apology and a status note, since you closed this shortly after my Aug 10 push. Two things went wrong on my side that day: the explanation comment I posted came out as a broken one-line path instead of the intended text (now fixed above), and the dev-sync I pushed contained a test-compile error in `DamengCreateTableSqlBuilderTest` — two of the PR-era cross-catalog tests still assigned `build()`'s result to a `String`, but current dev's builder returns `List<String>`, so the whole `connector-jdbc` module failed test-compile in CI. A red wall of CI plus a garbage comment on a rebase you didn't ask for is a rough thing to wake up to, and I'm sorry for that. The compile fix is a 2-line adaptation (join the returned statements before asserting) and is ready on my side, along with a fresh sync to today's dev. Since the PR is closed I can no longer push to the branch (maintainer-edit access ends with the close). If you're still interested in landing this test-coverage work — and reviewers were positive on its substance — reopening the PR is all it takes and I'll push the fix immediately. If you'd rather not continue, that's entirely your call and thanks for the contribution regardless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
