DanielLeens commented on PR #11215:
URL: https://github.com/apache/seatunnel/pull/11215#issuecomment-5322411798
Thanks @SEZ9 for following up.
The commit is `e14f48bf` ("[Fix][Zeta] Use public cluster-safe API in
cluster metrics", 2026-07-06), which is also the current PR head. In
`ClusterMetricExports.resolveClusterSafe()` it drops the
`InstanceMBean`/`ManagementService` lookup and the local-member-safe fallback
(`hasOngoingMigration() && hasSafeLocalMemberState()`) entirely, replacing it
with:
```java
private boolean resolveClusterSafe() {
HazelcastInstanceImpl hazelcastInstance = getNode().hazelcastInstance;
PartitionService partitionService =
hazelcastInstance == null ? null :
hazelcastInstance.getPartitionService();
return partitionService != null && partitionService.isClusterSafe();
}
```
That's the cluster-level `PartitionService.isClusterSafe()` API directly, so
the false-positive-from-local-evidence path is gone — there's no more
MBean-missing branch to fall back on, it always resolves through the
cluster-wide signal now. I re-verified this on the current head and it still
holds.
On the sync ask: rechecked just now — `mergeStateStatus` is still `DIRTY` /
`mergeable` is `CONFLICTING` against `dev`, and the branch has drifted further
(`ahead_by=3`, `behind_by=329`, up from `behind_by=303` when I last checked).
`Build` is green on the current head. @dybyte, syncing with the latest `dev`
and resolving the conflicts is still the one remaining action item to get this
to a mergeable state for final review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
