DanielLeens commented on PR #11641: URL: https://github.com/apache/seatunnel/pull/11641#issuecomment-5322791915
Pushed `be6b805` addressing the Aug 16 pass, and filed the tracking issue every pass since Aug 7 has asked for: - **Issue 1**: the production-side startup window (`/metrics` answering 500 + stack-trace body while `CoordinatorService` is still wiring) is now tracked in #11846, and the comment block above the poll links it, so the poll is documented as the mitigation rather than the fix. - **Issue 2**: the `REQUEST_TIMEOUT_MILLIS` Javadoc no longer claims `atMost` is only checked between attempts — re-verified against `awaitility-4.2.0` bytecode (`ConditionAwaiter.await()` bounds each evaluation with `getUninterruptibly(future, duration)` and cancels it after), and restated with the accurate justification: retry-within-budget, no evaluation thread left blocked, and a body-bearing failure instead of a bare timeout. - **Issue 3**: dropped `ignoreExceptionsInstanceOf(IOException.class)`; transport failures are now rethrown as `AssertionError` inside `assertMetricsExposed()`, so they are still retried under the same bound but the last connection error survives into the timeout report (confirmed `AssertionCondition` only records `AssertionError` messages). - **Issue 4**: both assertion messages use the `Supplier` overloads now, so nothing is concatenated on a passing poll. - **Issue 5**: left as-is per the review's own fallback position — the fixed port matches every sibling REST test in this module, and with Issues 3/4 fixed a conflict now fails with the foreign response visible in the message rather than an opaque timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
