davidzollo commented on PR #9976: URL: https://github.com/apache/seatunnel/pull/9976#issuecomment-5322956615
All three findings from the 2026-08-10 review are addressed on the new head, plus a fresh dev sync: - **Issue 1 (blocker)**: all 14 stale pins across the 7 PR-side-only job blocks bumped to `actions/checkout@v4` / `actions/setup-java@v4`. Your diagnosis of the mechanism was exactly right — those blocks exist only on this branch, so the dev-sync merge had nothing to reconcile them against. - **Issue 2**: removed `log_time_and_space()` / `get_available_space()` and the orphan `start_time`/`start_space` captures — leftovers of keeping dev's script body, which never calls them. - **Issue 3**: deleted the unreachable iceberg/hbase substring-strip lines from `all-connectors-it-2`. The dev sync brought two more things worth noting: - dev independently started extracting elasticsearch/cdc-mysql/iceberg/hbase from the shard pool (7-shard layout, its own elasticsearch/mysql-cdc jobs). Resolved by keeping this branch's strict-superset design: 8-shard layout retained, dev's two duplicate job definitions dropped in favor of this branch's versions (duplicate YAML job keys would silently shadow one another). - dev's new `test_update_modules_check.py` calls `build_sub_it_modules()` with module lists that don't contain every dedicated module — which would crash against this branch's bare `list.remove()` calls. Converted all removals to the guarded form (also closing the fragility you noted), kept dev's test unchanged, and added a stricter case asserting all ten dedicated-lane suites stay out of all eight shards plus a sparse-input case pinning the guarded behavior — which is also the unit test you suggested for the shard-membership logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
