davidzollo commented on PR #10221: URL: https://github.com/apache/seatunnel/pull/10221#issuecomment-5322956792
Both findings from the 2026-08-10 review are addressed on the new head: - **Issue 1 (blocker)**: `CastFunctionTypeTest` now asserts `CastFunction.VARBINARY` resolves to `PrimitiveByteArrayType`, matching the existing BYTES/BINARY pattern at the same spot. - **Issue 2**: took your suggestion — the unreachable `case VARBINARY:` labels in `JsonToRowConverters` and `JsonPathTransform` are removed. Your reachability analysis checks out in source: `PrimitiveByteArrayType.getSqlType()` hard-codes `SqlType.BYTES` and nothing else produces `SqlType.VARBINARY` from a data type, so those switches can never see it. The feature's real footprint is now exactly the type-string parser + the SQL CAST function, which also makes the answer to @zhangshenghang's necessity question visible in the diff itself. Also merged current dev (the Dead Letter Queue feature landed since) — clean, no conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
