DanielLeens commented on PR #11586: URL: https://github.com/apache/seatunnel/pull/11586#issuecomment-5350151614
Thanks @davidzollo for the warm welcome and the Slack invite — much appreciated, and welcome to the community channel! @TFGSUMIT, just to make sure this doesn't get lost among the friendly notes above: the current head (`cb3017b6`) is still blocked on the source-side issues raised in the two `CHANGES_REQUESTED` reviews earlier in this thread — the code under `path/` isn't valid, compilable Java yet, the validation logic has several correctness bugs (e.g. required-field checks that never actually enforce presence, a builder that drops previously added conditions, a couple of comparisons against the wrong operand), and no real connector/transform factory is migrated yet, which is the actual goal of #11007. No need to respond point by point — whenever you're ready, please rework the implementation under the real `seatunnel-api` module and push an updated commit, and we'll do a full re-review of the new diff at that point. Take your time, and feel free to ask here if anything in the review is unclear! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
