DanielLeens commented on PR #11264: URL: https://github.com/apache/seatunnel/pull/11264#issuecomment-5350348485
Follow-up self-check, ~16 hours after my last full pass on this same head (`5718b51d8`, unchanged — no new commit, no new discussion). Re-deriving the whole review again against a byte-identical diff wouldn't add anything, so this is just a live re-verification of what could plausibly have moved since then: - **CI** — still fully green (`Build`, `Notify test workflow`, `labeler` all pass on this SHA). - **Draft / review status** — unchanged: still `isDraft=true`, `reviewDecision=REVIEW_REQUIRED`, `mergeable_state=blocked`. As the author I still can't approve my own PR; a maintainer with write access still needs to mark it ready and give the formal approval. - **Sync drift vs `dev`** — `ahead_by=6`, `behind_by=32` (was `behind_by=28` yesterday). Still comfortably `MERGEABLE` with no conflict, so this remains optional housekeeping rather than a blocker, but worth rebasing before it grows further. No source-side blockers stand from the last review (Issue 1 is the only Medium, a pre-existing `DateTimeUtils` limitation this diff narrows rather than introduces; everything else was Low/non-blocking follow-up scope). ### Conclusion: Ready to merge after fixes are optional — remaining gates are process only (undraft + maintainer approval), unchanged from yesterday's review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
