SEZ9 commented on issue #11052: URL: https://github.com/apache/seatunnel/issues/11052#issuecomment-5358317498
Thanks for the well-structured proposal. Since Expression is part of the public API in seatunnel-api, Option 1 (deprecate first, remove in a later API cleanup window) seems safer for potential downstream/connector authors. Could a committer confirm the preferred rollout path before implementation starts? Please confirm the scope of in-repo migration: a quick audit of all usages of Expression (e.g., ConditionRule, ConditionalRequiredOptions, ConfigValidator, REST metadata rendering, Map<Expression, OptionRule> keys) with a checklist in this issue would help track the change and verify the stated non-goals (no behavior/message/rendering changes). If you plan to work on this, please note that Condition<?> will be used as a map key after the change — verify its equals/hashCode semantics match what Expression provided today, and add tests covering AND/OR chain equality to avoid subtle regressions. <!-- streview-comment:391 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
