zhang-arvin commented on PR #11901:
URL: https://github.com/apache/seatunnel/pull/11901#issuecomment-5365971726
@DanielLeens Thanks for the thorough review! I have addressed the four
blocking/medium issues:
1. **Issue 1 (compile error)**: Added the missing `handleAutoscaler` method
in `RestHttpGetCommandProcessor.java`
2. **Issue 2 (SLF4J format)**: Fixed broken `{:.2f}` format specifiers to
proper `{}` with `String.format` for numeric values in `WorkerAutoscaler.java`
3. **Issue 3 (shutdown hook)**: Added `stopWorkerAutoscaler()` call in
`CoordinatorService.clearCoordinatorService()` for the
full-shutdown-while-master path
4. **Issue 4 (unit tests)**: Added `WorkerAutoscalerTest.java` with test
coverage for the autoscaler
All changes compile successfully (verified with `./mvnw install
-DskipTests`). PTAL when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
