SEZ9 commented on PR #11538: URL: https://github.com/apache/seatunnel/pull/11538#issuecomment-5366240739
Thanks @goutamadwant — confirming your read of the current state is correct. - CI: the required `Build` check on the latest head (`e88fdb90`) finished with **SUCCESS** (run 94934440297), and @DanielLeens's review landed as **Approve** (review 4948882257). - Code: no outstanding source-level blockers. As noted in the review, every prior-round finding (env-option smuggling, `--restore-with-checkpoint` bypass, transform-parallelism escape, the credential-leaking schema log, the uncaught-`ParameterException` UX gap) was re-verified as fixed on this head. - Merge gate: the remaining `BLOCKED` status is the branch-protection review-count requirement, not anything on your side — since @DanielLeens's approval doesn't carry write-level permissions, a maintainer review is the correct next step. Two concrete asks so the non-blocking items from the review don't get lost after merge: 1. Please open a follow-up issue for the documented idle/absolute timeout for sample mode, and link it back to this PR. 2. Please open a second follow-up (or fold it into the same issue if you prefer) for restoring the end-to-end coverage. Once those trackers exist, nothing else is needed from you. Thanks for the disciplined follow-through across the review rounds — this is in good shape. <!-- streview-comment:414 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
