SEZ9 commented on PR #11493: URL: https://github.com/apache/seatunnel/pull/11493#issuecomment-5366248338
Thanks @DanielLeens — and apologies for the formatting confusion on my side; glad the earlier comment was complete after all. Ironically, this latest comment does appear to be cut off mid-sentence: it ends at "The Qdra" in the middle of your second blast-radius bullet. Could you repost or edit to include the rest? I don't want to guess at what that second finding is. On the individual points: **F2 / F3 / F4** — Great, we're aligned. Since these map to your own tracked Issue 2, Issue 3/13, and Issue 14, I'll just wait for the fix commit. Head is still `8ddb8ff420f0`, so nothing to re-review yet. Concretely I'm expecting: (a) validation so non-JSON text can't silently reach a native JSON sink rather than relying on the StarRocks load boundary alone, (b) fail-fast rejection at StarRocks sink initialization for native JSON columns with the default CSV Stream Load format, and (c) resolution of the silent `PARSE_JSON` skip when a Snowflake sink uses a user-defined query — either wrap correctly or fail loudly, not defer to a mid-run server error. **F1** — Your precedent argument is fair: the timezone-aware timestamp remap documented in `docs/en/introduction/concepts/incompatible-changes.md` did ship unconditionally with only a migration doc, so I won't insist on a `json.type.mapping` opt-out flag as a hard merge condition. But that precedent only holds if the migration doc is actually complete, and by your own 2026-08-19 re-verification it isn't: Doris-source → SelectDB-Cloud-sink pipelines hard-fail and SelectDB Cloud isn't listed as affected anywhere in the incompatible-changes doc. So my concrete asks for F1 are: 1. Add SelectDB Cloud (and whatever the truncated second bullet covers) to the affected list in `docs/en/introduction/concepts/incompatible-changes.md`. 2. Confirm in the doc which source mappings change — Snowflake VARIANT, Doris JSON/JSONB, StarRocks JSON — so upgrading users can audit their pipelines. Once the truncated comment is completed and a new commit lands addressing F2–F4 plus the F1 doc completeness, I'll do the next pass. Thanks for the thorough back-and-forth on this. <!-- streview-comment:429 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
