hutiefang76 commented on PR #11271: URL: https://github.com/apache/seatunnel/pull/11271#issuecomment-5371638523
Addressed the blocking restore regression in 79db105ea. I removed the two tableWatermarks-based exclusions. A restored table must still be included in the newly assigned incremental split; tableWatermarks supplies that splits resumed startup offset rather than marking the table as completed. The regression test now restores a split, requests the next split, and verifies both that the table is reassigned and that its restored startup offset is preserved. Verified locally with JDK 8: - ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base -Dtest=IncrementalSplitAssignerTest test (4 tests, 0 failures/errors) - ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base spotless:check - git diff --check The earlier empty-bucket handling remains unchanged. Thank you for the detailed review; could you please re-review the current head when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
